Add infra for lettuce examples #875
Merged
+66
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Lettuce we have multiple APIs (async, reactive, etc) and should provide examples for each API variant. To achieve it multiple changes were introduced: - Add "label" attribute in clients configs and refer to the client example by label instead of language - Remove hardcoded mapping Label -> Lang from the config.toml - Prefix copied examples with client name to allow identical naming - Add configs for Lettuce Async and Reactive APIs
|
|
andy-stark-redis
requested changes
Nov 15, 2024
| }, | ||
| "examples": { | ||
| "git_uri": "https://github.com/redis/lettuce", | ||
| "dev_branch": "doctests", |
There was a problem hiding this comment.
Is it possible to have the examples folder in the main branch? We've tried to do that with the other client libs so that errors against the latest build can be spotted quickly.
There was a problem hiding this comment.
I used the doctests branch just to make changes to the docs testable. As soon as the PR in lettuce is merged, it can be pointed to the main branch.
There was a problem hiding this comment.
That's excellent, thanks. Great idea :-)
| }, | ||
| "examples": { | ||
| "git_uri": "https://github.com/redis/lettuce", | ||
| "dev_branch": "doctests", |
There was a problem hiding this comment.
Same as for async above.
There was a problem hiding this comment.
See my reply above. Thanks
Co-authored-by: andy-stark-redis <[email protected]>
|
If @andy-stark-redis is satisfied, then so am I. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.